search

CCHits / Website

5 stars 2 forks source link

Attempt at fixing #102 #103

Closed computamike closed 6 years ago

computamike commented 6 years ago

These changes should allow a developer to download the code from GitHub and work with Homestead to develop ccHits. This PR adds missing folders required (media/shows media/tracks) and adds suitable .gitignore files for these folders. In addition the class_UI file now performs a check as to whether the environment supports Apache.

computamike commented 6 years ago

Suggest that some wiki article be created documenting how to set up your own CCHits instance for development and testing -

JonTheNiceGuy commented 6 years ago

Having created (and removed) a test.php, I'm not sure the apache_ specific calls are actually available on Dreamhost anyway*... So, I don't think this is an issue. Accordingly, I'm happy with this PR.

@ymauray @thelovebug, thoughts?

ymauray commented 6 years ago

I'd rather have the code removed if it's not used. Also, the change in the main .gitignore file seems redundant with the ones in both .gitignore in media/shows and media/tracks But I may be wrong on this.

JonTheNiceGuy commented 6 years ago

Agreed on the gitignore front @ymauray - @computamike; can you pull the lines from the main .gitignore or remove the media/*/.gitignore files?

computamike commented 6 years ago

Have removed the 2 lines from .gitignore

JonTheNiceGuy commented 6 years ago

Awesome! Cheers for that @computamike! Merged!

JonTheNiceGuy commented 4 years ago

@all-contributors please add @computamike for code

allcontributors[bot] commented 4 years ago

@JonTheNiceGuy

I've put up a pull request to add @computamike! :tada: