search

CCI-MOC / ORE

MOC OpenStack Research Environment
Apache License 2.0
2 stars 3 forks source link

osprofiler update #27

Open EmreAtes opened 6 years ago

EmreAtes commented 6 years ago

osprofiler can support jaeger in the master branch, so I'm trying to create an ORE with the master version of osprofiler.

So far, I tried to change local.conf to include OSPROFILER_BRANCH and OSPROFILER_REPO, with no luck (the old version of osprofiler is fetched). I'll try it more systematically tomorrow and update any progress over here.

ghost commented 6 years ago

Devstack doesn't pull from the URL specified for a plugin in local.conf for some reason. What you can do as an interim measure is set your osprofiler fork with jaeger tracing in as a remove in /opt/stack/osprofiler git remote add upstream git pull upstream master That should get you a copy of osprofiler with jaeger support where ever your Devstack installation is. In /opt/stack/osprofiler run sudo python setup.py install --force which will install your version of osprofiler. Then restart the OpenStack services.

EmreAtes commented 6 years ago

That's how I normally swap osprofiler with mine, but to store in jaeger I had to change connection string to jaeger://..., so I wanted to use local.conf, but overall messed up my devstack as a result. I'll try starting from scratch and changing the files in /etc

ghost commented 6 years ago

When you changed the connection string in local.conf, did the conf files in /etc/service show the new connection string?

EmreAtes commented 6 years ago

after I changed the connection string, I got an error saying jaeger is not supported as a backend, because in the version collected from stable/pike it's not supported, so I couldn't successfully run stack.sh after I changed the connection string.

ghost commented 6 years ago

It might work if you ignore CONNECTION_STRING parameter and just set the connection_strings in post config. The whole point of CONNECTION_STRING is that you could set it in one place and Devstack would set it as the connection_string in the openstack services, but Devstack doesn't do that/you still have the set the connection string in post config regardless of what it is.

ghost commented 6 years ago

Also, is there an openstack release where jaeger backend is supported, for example stable/queens?

EmreAtes commented 6 years ago

The support came with this commit https://github.com/openstack/osprofiler/commit/eb6376c052a71e709039c260ffc1856b56e49902 stable/rocky supports it, as well as master.

ghost commented 6 years ago

would it be useful to upgrade Devstack?

EmreAtes commented 6 years ago

I'm not sure. I was trying to install the new version of osprofiler while keeping everything else the same version, which is becoming more challenging than I expected (now getting a ContextualVersionConflict exception from keystone).

I think we can talk about this in the next project meeting (tomorrow), and if the jaeger backend is something we really want, we can talk about possible solutions (e.g., porting that jaeger patch to our queens version osprofiler or upgrading devstack).