search

CCI-MOC / flocx-market

2 stars 9 forks source link

flocx_market put contract api is not working #107

Closed DanNiESh closed 5 years ago

DanNiESh commented 5 years ago

When I want to make a put request to marketplace contract, the flocx-market app returns error: save() missing 1 required positional argument: 'context'. I think it's because the code here: https://github.com/CCI-MOC/flocx-market/blob/ac7562e0780159417118e826e2d69048d34af66a/flocx_market/api/contract.py#L46 doesn't pass the parameter 'context' in to save() method. Probably the same issue with delete api and the api in bid.py.

DanNiESh commented 5 years ago

@fvukelic

tzumainn commented 5 years ago

Ah, yep, this is from something that @ljmcgann is working on. Leo, could you update your followup PR to update the contract business object?

ljmcgann commented 5 years ago

The importance of unit testing with assert_called_with instead of assert_called_once I suppose

ljmcgann commented 5 years ago

I have updated the pr

tzumainn commented 5 years ago

This should be fixed now then! @DanNiESh can you try it, and close this issue if it works?

DanNiESh commented 5 years ago

Thanks! It works.