search

CCI-MOC / flocx-market

2 stars 9 forks source link

Oslo Configuration #11

Closed ljmcgann closed 5 years ago

ljmcgann commented 5 years ago

Oslo configuration is set up on MOC/flocx as opposed to on Filip's WIP code.

tzumainn commented 5 years ago

Looks good - thanks!

tzumainn commented 5 years ago

Resolved all of @larsks 's comments, so merging.

larsks commented 5 years ago

@tzumainn I think that merge was premature: pull requests with code need to include unit tests for that code (and commit messages should be a little more filled out). @ljmcgann it would be great if you could prioritize writing some unit tests for this code before moving on to something else. Thanks!

tzumainn commented 5 years ago

@larsks I think it's fair to have slightly more descriptive commit messages. However, conf tests are kind of difficult to write; are the tests checking to see that defaults are being set, or... ? Note that Ironic and Nova don't really have much in the way of tests for conf code either: