search

CCI-MOC / flocx-market

2 stars 9 forks source link

[WIP] Use an integer primary key column #134

Closed larsks closed 3 years ago

larsks commented 5 years ago

Introduce an integer primary key column for all tables. The object UUID will continue to be the externally visible id for objects, but using an integer primary key reduces the storage required for foreign key references.

Closes #124

codecov-io commented 5 years ago

Codecov Report

Merging #134 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   93.66%   93.67%   +0.01%     
==========================================
  Files          51       51              
  Lines        1972     1976       +4     
==========================================
+ Hits         1847     1851       +4     
  Misses        125      125
Impacted Files Coverage Δ
flocx_market/db/sqlalchemy/models.py 98.59% <100%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82e3170...464b3ab. Read the comment docs.

tzumainn commented 5 years ago

I admit, I'd be nervous merging something like this until post-devconf!

larsks commented 5 years ago

You'll notice the commit is marked [WIP] :). I've updated the PR to match. I'm concerned that this will break despite passing tests because we are handling the offer-contract-relationship table incorrectly.