search

CCI-MOC / flocx-market

2 stars 9 forks source link

we should allow multiple open offers on the same server as long as the times do not overlap #137

Open tzumainn opened 5 years ago

ljmcgann commented 5 years ago

Are two offers allowed to overlap at endpoints? Like if start_time for the new offer equals end_time of previous, is this ok?

tzumainn commented 5 years ago

Good question - I'd say yes, I guess?

ljmcgann commented 5 years ago

Ironic nodes don't get reinitialized after being used right? Being that offers only go to one bid, This second offer going to another bid would allow a bidder to be on the hardware at the same time as another bidder for all of one moment. But with network latency and unsynchronized clock nonsense, it seems like some kind of race condition could occur and the new bidder might have slightly more time overlapping with the old bidder and let the old bidder be on the node at the same time as the new one. In fact, do we think there should be some kind of buffer between times to allow for creation?

ljmcgann commented 5 years ago

Or am I way overthinking this and stretching to apply my academics into the problem

tzumainn commented 5 years ago

Actually, ironic nodes do need to get cleaned after being released, so you raise a relevant point. I think it may be an issue that's out of scope for this issue, however.

ljmcgann commented 5 years ago

Yeah cleaned but not reinstantiated is what I meant. There needs to be a buffer from end_time to next start_time but I wont bother with that for now I guess

ljmcgann commented 5 years ago

Also, I will create a check to make sure start_time is actually before end_time. Seems like we need this