search

CCI-MOC / flocx-market

2 stars 9 forks source link

Issue137 #142

Open ljmcgann opened 5 years ago

ljmcgann commented 5 years ago

A fix for issue 137. Two offers with the same server_id can now be posted to the marketplace. Raises the question of offer proximity. Copy-pasted from the issue Ironic nodes don't get reinitialized after being used right? Being that offers only go to one bid, This second offer going to another bid would allow a bidder to be on the hardware at the same time as another bidder for all of one moment. But with network latency and unsynchronized clock nonsense, it seems like some kind of race condition could occur and the new bidder might have slightly more time overlapping with the old bidder and let the old bidder be on the node at the same time as the new one. In fact, do we think there should be some kind of buffer between times to allow for creation? But this is a separate issue that should be created

codecov-io commented 5 years ago

Codecov Report

Merging #142 into master will increase coverage by 0.53%. The diff coverage is 97.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage    92.9%   93.44%   +0.53%     
==========================================
  Files          52       51       -1     
  Lines        2114     2104      -10     
==========================================
+ Hits         1964     1966       +2     
+ Misses        150      138      -12
Impacted Files Coverage Δ
flocx_market/tests/unit/api/test_app_bid.py 100% <ø> (ø) :arrow_up:
flocx_market/tests/unit/api/test_app_offer.py 100% <ø> (ø) :arrow_up:
flocx_market/tests/unit/db/sqlalchemy/test_api.py 97.4% <100%> (+0.88%) :arrow_up:
flocx_market/db/sqlalchemy/api.py 95.5% <100%> (+1.56%) :arrow_up:
flocx_market/api/offer.py 96.66% <100%> (+4.77%) :arrow_up:
flocx_market/db/sqlalchemy/models.py 96.03% <91.17%> (-2.47%) :arrow_down:
...s/unit/api/test_app_offer_contract_relationship.py 100% <0%> (ø) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 736af76...f0fa5c7. Read the comment docs.