ljmcgann commented 5 years ago

Uses the keystonemiddleware package to require any user to have a valid token in order to query the api. Need to add tests for this still (and could use direction in doing so as this commit isn't self contained. It depends on the config file at /etc/flocx-market as well as deploying an application on a port)

tzumainn commented 5 years ago

Thinking it about, you could probably do a test where you don't set the auth_strategy to noauth, and just verify that the app rejects the request.

codecov-io commented 5 years ago

Codecov Report

Merging #39 into master will decrease coverage by 0.42%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   90.28%   89.86%   -0.43%     
==========================================
  Files          26       26              
  Lines         566      572       +6     
==========================================
+ Hits          511      514       +3     
- Misses         55       58       +3

Impacted Files	Coverage Δ
flocx_market/cmd/api.py	`0% <0%> (ø)`	:arrow_up:
flocx_market/tests/unit/api/test_app.py	`100% <100%> (ø)`	:arrow_up:
flocx_market/api/app.py	`94.44% <66.66%> (-5.56%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07db818...88f2f84. Read the comment docs.

tzumainn commented 5 years ago

Looks good - thanks!

CCI-MOC / flocx-market

Add Keystone authentication to REST API #39

Codecov Report