search

CCI-MOC / flocx-market

2 stars 9 forks source link

WIP | All matching Offers #66

Closed aliraza0337 closed 5 years ago

aliraza0337 commented 5 years ago

TG-105, This returns the list of matching offers to specific criteria. This pull request all fixes some of the issues with previous matcher code i.e. previously we consider "null" as an operator rather than None. Also if a user doesn't submit a valid operator in the matching criteria, we throw an exception.

codecov-io commented 5 years ago

Codecov Report

Merging #66 into master will increase coverage by 1.4%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #66     +/-   ##
=========================================
+ Coverage   85.28%   86.69%   +1.4%     
=========================================
  Files          26       27      +1     
  Lines         503      541     +38     
=========================================
+ Hits          429      469     +40     
+ Misses         74       72      -2
Impacted Files Coverage Δ
...sts/unit/db/sqlalchemy/test_all_matching_offers.py 100% <100%> (ø)
flocx_market/tests/unit/test_matcher.py 100% <100%> (ø) :arrow_up:
flocx_market/matcher.py 100% <100%> (+1.49%) :arrow_up:
flocx_market/api/offer.py 36.66% <0%> (+3.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4747694...405183c. Read the comment docs.