search

CCI-MOC / flocx-market

2 stars 9 forks source link

oslo configuration #7

Closed ljmcgann closed 5 years ago

tzumainn commented 5 years ago

Thanks for the PR!

I think I'd start by separating out the oslo config updates from everything else - db, tests, etc. I'd suggest creating a new branch off of master, copying the relevant conf/* files, and perhaps making a new PR.

There are a few things missing: updates to setup.cfg, and additions to etc/flocx_marketplace, similar to what esi-leap has. Take a look, and let me know if you have any questions regarding what's going on there!

Don't forget to run pep8 before committing; that'll catch things like adding a newline at the end of the file, and other formatting issues like that.

This is a good start!

larsks commented 5 years ago

...and I will remind you about https://blog.oddbit.com/post/2019-06-14-git-etiquette-commit-messages/, specifically: when you're making "fixing the previous commit" sorts of changes, don't make a new commit; just commit --amend and then update the PR.

larsks commented 5 years ago

Also, in addition to what Mainn said about splitting things up, I would just get rid of AUTHORS and ChangeLog; that information is better provided by git log. While there are arguments for a curated changelog of some sort, there are better mechanisms for producing one (and I think we're better off without it right now).