search

CCI-MOC / flocx-market

2 stars 9 forks source link

Removed OfferApi database model #75

Closed tzumainn closed 5 years ago

tzumainn commented 5 years ago

The OfferApi model doesn't make sense as a way to run database operations on an Offer. This change removes the class and puts those operations as single functions within flocx_market/db/sqlalchemy/offer_api.py, as well as moving the to_dict() function into the offer model. Lastly, it adds a test for offer updates.

Addresses #73

codecov-io commented 5 years ago

Codecov Report

Merging #75 into master will increase coverage by 0.04%. The diff coverage is 98.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   90.23%   90.28%   +0.04%     
==========================================
  Files          26       26              
  Lines         553      566      +13     
==========================================
+ Hits          499      511      +12     
- Misses         54       55       +1
Impacted Files Coverage Δ
flocx_market/tests/unit/db/sqlalchemy/test_api.py 100% <100%> (ø)
flocx_market/db/sqlalchemy/models.py 100% <100%> (ø)
flocx_market/tests/unit/api/test_app_offer.py 100% <100%> (ø) :arrow_up:
flocx_market/api/offer.py 100% <100%> (ø) :arrow_up:
flocx_market/db/sqlalchemy/api.py 95.65% <95.65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a59c1c...3c5ccb1. Read the comment docs.