search

CCI-MOC / flocx-market

2 stars 9 forks source link

Create bids business object #86

Closed aliraza0337 closed 5 years ago

aliraza0337 commented 5 years ago

This PR implements the Business Layer for bid API. This is WIP.

codecov-io commented 5 years ago

Codecov Report

Merging #86 into master will decrease coverage by 0.42%. The diff coverage is 95.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   97.63%   97.21%   -0.43%     
==========================================
  Files          29       33       +4     
  Lines         762      861      +99     
==========================================
+ Hits          744      837      +93     
- Misses         18       24       +6
Impacted Files Coverage Δ
flocx_market/tests/unit/objects/test_object_bid.py 100% <100%> (ø)
flocx_market/objects/__init__.py 100% <100%> (ø) :arrow_up:
flocx_market/objects/bid.py 100% <100%> (ø)
flocx_market/objects/base.py 100% <100%> (ø)
flocx_market/api/bid.py 100% <100%> (ø) :arrow_up:
flocx_market/objects/fields.py 79.31% <79.31%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78e92a5...db4987d. Read the comment docs.

tzumainn commented 5 years ago

I think this is really close! Left a few more comments. You also want to update objects/init.py to register the new object class (similar to https://github.com/CCI-MOC/esi-leap/blob/master/esi_leap/objects/__init__.py)

tzumainn commented 5 years ago

Looks good to me, and it looks like you addressed @larsks comments so I'll merge. Thanks!