search

CCI-MOC / flocx-market

2 stars 9 forks source link

Oslo --WIP #9

Closed ljmcgann closed 5 years ago

ljmcgann commented 5 years ago

Oslo configuration is set up. Passes all tox tests.

tzumainn commented 5 years ago

Hi! I think you may have created a branch off of a checkout of Filip's flask code. I think you want to create a new branch off of master instead. The final diff should only be 5-6 files.

tzumainn commented 5 years ago

Okay, I see what you did! Big plus for updating the Flask code to use the oslo config. For the purposes of this commit though, we want to not have the bulk of the flask code in here.

I'd suggest creating a new fresh branch, and just copying over the conf/*.py files (including flask.py; that's fine) as well as updates to setup.cfg, the conf generator, etc. Then once that PR is merged, put a review on Filip's PR asking him to use the new configuration options you have kindly provided :)

tzumainn commented 5 years ago

One last thing I'd add to this PR: an update to the README explaining how to run the config generator.

tzumainn commented 5 years ago

(Also one minor note: I'd refer to this as oslo config, and not just oslo; there are other oslo libraries for other functionality.)