search

CCI-MOC / flocx-market

2 stars 9 forks source link

Expiration of Contracts and Bids #95

Closed ljmcgann closed 5 years ago

ljmcgann commented 5 years ago

Expanded functionality for the manager service to expire bids and contracts. Expands database api and business objects as needed to accomplish this. TG-156

ljmcgann commented 5 years ago

This code can't be finished until Ali finishes the contracts business objects

codecov-io commented 5 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.38%. The diff coverage is 86.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   92.14%   91.76%   -0.39%     
==========================================
  Files          45       45              
  Lines        1312     1385      +73     
==========================================
+ Hits         1209     1271      +62     
- Misses        103      114      +11
Impacted Files Coverage Δ
flocx_market/tests/unit/objects/test_object_bid.py 100% <100%> (ø) :arrow_up:
flocx_market/tests/unit/db/sqlalchemy/test_api.py 100% <100%> (ø) :arrow_up:
flocx_market/objects/bid.py 96.96% <100%> (+0.67%) :arrow_up:
flocx_market/objects/contract.py 95.45% <100%> (-1.92%) :arrow_down:
flocx_market/db/sqlalchemy/api.py 97.84% <100%> (+0.09%) :arrow_up:
..._market/tests/unit/objects/test_object_contract.py 100% <100%> (ø) :arrow_up:
flocx_market/manager/service.py 72.72% <57.14%> (-10.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0422471...2725895. Read the comment docs.

tzumainn commented 5 years ago

Looks good! The contract business object layer stuff just got merged, so I believe this can be completed now.