search

CCI-MOC / flocx-market

2 stars 9 forks source link

Implement business object layer for contracts #96

Closed aliraza0337 closed 5 years ago

aliraza0337 commented 5 years ago

This implements the contract object of BO. TG-151.

codecov-io commented 5 years ago

Codecov Report

Merging #96 into master will increase coverage by 0.58%. The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   91.56%   92.14%   +0.58%     
==========================================
  Files          43       45       +2     
  Lines        1257     1312      +55     
==========================================
+ Hits         1151     1209      +58     
+ Misses        106      103       -3
Impacted Files Coverage Δ
..._market/tests/unit/objects/test_object_contract.py 100% <100%> (ø)
flocx_market/objects/__init__.py 100% <100%> (ø) :arrow_up:
flocx_market/tests/unit/api/test_app_contract.py 100% <100%> (ø) :arrow_up:
flocx_market/api/contract.py 96.66% <94.44%> (+7.77%) :arrow_up:
flocx_market/objects/contract.py 97.36% <97.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0485cd...51b5352. Read the comment docs.

tzumainn commented 5 years ago

Looks good! Could you just change your commit message subject to something a bit more straightforward - 'Implement business object layer for contracts' or something?

aliraza0337 commented 5 years ago

Done

tzumainn commented 5 years ago

Thanks!