CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Make travis a little faster #1008

Closed naved001 closed 6 years ago

naved001 commented 6 years ago

This PR does a few things to address #992 (I think we can do more stuff)

Build finishes in under 6 minutes for unit tests & linters and 9 for the rest of the integration/deployment tests.

I think it's time we rearrange the CI folder a little, but haven't thought exactly how to.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 1920


Files with Coverage Reduction New Missed Lines %
hil/flaskapp.py 2 0.0%
hil/commands/util.py 4 0.0%
hil/commands/db.py 5 0.0%
hil/client/extensions.py 5 0.0%
hil/class_resolver.py 13 0.0%
hil/ext/auth/null.py 13 0.0%
hil/dev_support.py 13 0.0%
hil/commands/migrate_ipmi_info.py 13 0.0%
hil/server.py 16 0.0%
hil/network_allocator.py 19 0.0%
<!-- Total: 1975 -->
Totals Coverage Status
Change from base Build 1914: -55.2%
Covered Lines: 0
Relevant Lines: 2785

💛 - Coveralls
naved001 commented 6 years ago

I can't figure out how to put the addons under env. So it's still installing postgresql: "9.3", apache2 and libapache2-mod-wsgi for all env

zenhack commented 6 years ago

Coveralls is reporting a signficant drop in coverage; looks like it doesn't think the client lib is being covered anymore?

naved001 commented 6 years ago

Searching for "coverage dropped in coveralls" takes me to open github issues from other people :/

naved001 commented 6 years ago

@chemistry-sourabh @xuhang57 You guys know what's up with coveralls? I just moved my tests to a different folder (tests/unit/client.py to tests/integration/client.py), and coveralls think that the client library is not being tested.

xuhang57 commented 6 years ago

hmm, I don't have a clue yet. Something wrong with the client library tests for sure.

naved001 commented 6 years ago

I don't know why are travis results not showing here. Though you can see it on my fork https://travis-ci.org/naved001/hil Things that I found out:

naved001 commented 6 years ago

I am really puzzled why there is no coverage for integration tests (or any of the postgres builds). I can't reproduce this locally (running integration tests with postgres gives me expected coverage report).

zenhack commented 6 years ago

So, I have a thought:

I'm half tempted to suggest just junking coveralls. I basically trust us to insist on writing tests for new code, and if we're going to work on improving existing coverage, given that I'm not worried about regressions, I'd be fine with people just posting comments showing coverage before and after. There's only so much fighting with tooling that makes sense.

naved001 commented 6 years ago

There's only so much fighting with tooling that makes sense.

I am with you on this. I'll remove the last commit and remove coveralls.

naved001 commented 6 years ago

@zenhack all set now.

zenhack commented 6 years ago

LGTM