CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Fix a bug that was silencing errors from the server. #1010

Closed zenhack closed 6 years ago

zenhack commented 6 years ago

I caught this while working on OBMd stuff, which raises another question: right now OBMd doesn't follow the same error reporting convention as the HIL api server.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 1930


Changes Missing Coverage Covered Lines Changed/Added Lines %
hil/test_common.py 24 28 85.71%
<!-- Total: 25 29 86.21% -->
Totals Coverage Status
Change from base Build 1914: 0.2%
Covered Lines: 2165
Relevant Lines: 3905

💛 - Coveralls
naved001 commented 6 years ago

If it's simple enough, can we write a unit test for this?

zenhack commented 6 years ago

Hm, I think that's worth doing, but thinking about how it's a little fiddly. I'd like to wait until #1009 is merged, since I'll need to use the test client, and don't really want to deal with potential conflicts. I'll probably end up moving that into test_common, and have the test for this in a separate file from the existing client (integration) tests. I think I'll tag this one as "waiting on other change."

zenhack commented 6 years ago

Added a test.

zenhack commented 6 years ago

(Per the docstring at the top of the file, we'll want to merge your thing and then rename it).

ianballou commented 6 years ago

@zenhack we'll need to fix the merge conflicts here

zenhack commented 6 years ago

Rebased. I also did the rename suggested in the docstring, now that @naved001's pr is merged.

naved001 commented 6 years ago

Cool, merging.