search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Use github mirror instead of git.o.o #1018

Closed jeremyfreudberg closed 6 years ago

jeremyfreudberg commented 6 years ago

Just a test... not in the mood to learn how to run Travis without making a PR

ianballou commented 6 years ago

For future reference if this ever breaks, pip install -U requests[security] also fixes the certificate issue.

ianballou commented 6 years ago

Note: this fixes the current Travis certificate error.

zenhack commented 6 years ago

What does the [securty] extra actually contain? If the problem is a software support thing on our end, just specifying that in our config might be a better solution.

ianballou commented 6 years ago

@zenhack I'm not sure exactly what that contains, but in a quick test I found it also works. @jeremyfreudberg 's solution works fine though since it doesn't require any more installing.

jeremyfreudberg commented 6 years ago

@zenhack [security] adds a few extra packages, see here: https://github.com/requests/requests/blob/master/setup.py#L99

the solution that i have provided here would be prioritizing speed

zenhack commented 6 years ago

Ok. Could you add a comment mentioning why we're pulling from github? Should document the fact that this is purposeful, rather than just an arbitrary choice.

naved001 commented 6 years ago

@zenhack there's a comment now, you can merge this if you are satisfied.

zenhack commented 6 years ago

Works for me, merged.