search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Use dummy_verify fixture for running database auth unit tests #1022

Closed naved001 closed 6 years ago

naved001 commented 6 years ago

With the fixture it ran in 30 seconds and without it 40 seconds consistently on my local machine. We may not notice in travis because the variance between different travis runs is probably greater than 10 seconds. So do you guys think it's worth doing it or not @zenhack @Izhmash ?

zenhack commented 6 years ago

I'd rather not muck with this in the tests for the backend itself; this is disabling some of the functionality we should be testing. The problem this was originally trying to solve was a difference of half an hour, for tests that were conceptually unrelated. I think we should just put up with the 10 seconds.

naved001 commented 6 years ago

alright, cool.