Move show_console over to obmd

zenhack commented 5 years ago

This is the last API call that actually uses the drivertized API support. A subsequent PR will delete the old functionality.

Still futzing with travis; I'm getting an error in the CLI tests that I can't reproduce locally.

zenhack commented 5 years ago

Ok, tests are passing.

naved001 commented 5 years ago

https://github.com/CCI-MOC/hil/blob/c4057f747bbd956143cc0f4b84c7bd4c60360ac8/hil/model.py#L136 On a related node, how does this line of code even work in our tests. As far as I know we the url to enable the obm (which returns the token) is obmd_uri/node/<node-name>/token. But in that method we just do obmd_uri/path where path is just token in this case.

This is what I did locally to get it working:

         return requests.request(
             method,
-            self.obmd_uri + '/' + path,
+            self.obmd_uri + '/node/' + self.label + path,
             auth=('admin', self.obmd_admin_token),

But how are the integration tests passing then

zenhack commented 5 years ago

The obmd_uri field in the model is the path to that node in the obmd api, not the base path to the obmd api. so it includes the '/node/' + self.label already. This is per the spec.

naved001 commented 5 years ago

is the path to that node in the obmd api

ah, I forgot about that bit. I did the registration wrong in that case.

CCI-MOC / hil

Move show_console over to obmd #1034