search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Nic delete #1041

Closed naved001 closed 6 years ago

naved001 commented 6 years ago

Fixes #1039

There was one more issue with nic_delete. I added a check to make sure that we remove any networks before we are allowed to delete a nic.

One question, administrators can delete a nic on a node that belongs to some project. Should that be allowed? Our usual policy is to disallow deletion of something that is owned by a project (networks, nodes).

zenhack commented 6 years ago

Yeah, I think we should refuse to delete a nic on a node that is allocated to a project; if an admin wants to remove a nic, they need to free it first.

naved001 commented 6 years ago

cool, done.

zenhack commented 6 years ago

LGTM.