search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Split BlockedError to AttachedResourceError and PendingActionError #1044

Open RobinKaul opened 5 years ago

RobinKaul commented 5 years ago

I'm referring to issue #925 . Since there were two suggestions I am referring to the first one that was to replace BlockedError with a AttachedResourceError and PendingActionError. Also I noticed that in a lot of places the two new error types wouldn't fit into that particular case so I changed them to OBMError/ DuplicateError, etc. Please let me know if they need to be reverted. Also I was kind of swaying between a couple of the error names like when a node/ network is not free. I wasn't sure if they need to be named PendingActionError or AttachedResourceError so I named them the latter for now. One little thing I wanted to point out was that in the comments of the node_detach_network function in api.py, it mentioned it raises an error if there is a pending network action but then the error isn't raised.

RobinKaul commented 5 years ago

@zenhack quick followup about mentioning the new error types in UPGRADING.rst, has someone already posted a change for 0.5 and I can add to that? Or do I create a new PR for version 0.5? Side note: the formatting for the steps in version 0.4 is wonky. I will correct that too.

zenhack commented 5 years ago

There's no entry for 0.5 yet, because this will be the first user-visible change we've merged so far (@naved001 tagged 0.4 just the other day). So you'll have to add a new section to the document.