search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Just print whatever the exception is #1050

Closed naved001 closed 5 years ago

naved001 commented 5 years ago

For #1049

zenhack commented 5 years ago

I don't think this actually solves the problem -- we'll end up printing a stack trace, but it still doesn't include any extra info -- besides e.message, the FailedAPICallException only includes an error_type field, which is not printed.

Probably we should at least try to fit the HTTP status code in there somewhere.

naved001 commented 5 years ago

yeah, I don't know why I thought this would work. Also, when check_reserved raises an error it is not handled at all. I should just not handle all exceptions (except for the ones we know) and let there be a stack trace, so we don't accidentally hide something.

zenhack commented 5 years ago

Quoting Naved Ansari (2018-11-02 14:41:15)

I should just not handle all exceptions (except for the ones we know) and let there be a stack trace, so we don't accidentally hide something.

That too, though it's a conceptually separate issue from this one.