search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Use setuptools_scm to derive the version. #905

Closed zenhack closed 6 years ago

zenhack commented 6 years ago

This way we don't have to remember to update the version when we make a release; the version will be derived from the git tag (and stored in the package info if we make an sdist). We actually forgot this when we tagged v0.2!

zenhack commented 6 years ago

Weird, I get 0.3.dev45+g1709920.

naved001 commented 6 years ago

The number followed by 'g' is the commit number which is the same in both cases. Not sure what the rest of the numbers mean.

zenhack commented 6 years ago

See "Default versioning scheme" in:

https://pypi.python.org/pypi/setuptools_scm

Based on that, my result is what is expected. If you do git tag, what do you get? is there a v0.2 tag in your local repo?

naved001 commented 6 years ago

If you do git tag, what do you get?

channel-proposal v0.1 v0.1.1

Based on that, my result is what is expected.

It all makes sense now.

zenhack commented 6 years ago

Yeah, that would do it.

naved001 commented 6 years ago

@SahilTikale @mosayyebzadeh @izhmash can we get second review on this?

naved001 commented 6 years ago

2 sign offs, so merging.