search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

`get_port_networks()` doesn't read inactive vlans (on the powerconnect switch). #921

Closed naved001 closed 6 years ago

naved001 commented 6 years ago 
Trunking VLANs Enabled: 1511
                        1512 (Inactive)

VS

Trunking VLANs Enabled: 1511-1512

This was causing deployment tests to fail on the powerconnect switch. From the comment here it's not clear if this is the intended behavior or not.

zenhack commented 6 years ago

From the code it looks like the issue may actually be that it's split on to the next line.

naved001 commented 6 years ago

Since we are telling hil admins to create all VLANs that HIL will be using, do we still need to worry about reading inactive VLANs? I guess not, if you agree you can close this.

zenhack commented 6 years ago

Per the above, I don't think (Inactive) is what's causing the problem; I suspect it's the line break.

naved001 commented 6 years ago

I suspect it's the line break.

I think so too. So I think we should update the method to read the inactive VLANs too because those VLANs are allowed on that switchport and may get activated in the future.

naved001 commented 6 years ago

998 fixes this.