CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Unimplemented api calls in client library #924

Closed ianballou closed 6 years ago

ianballou commented 6 years ago

Neither Node's nor Switch's register() functions are implemented in the client library. Since every call should be accessible in the client library, this should be fixed.

zenhack commented 6 years ago

Yeah, I think there are a number of calls that aren't there. They're not hard to add. It would be good to make a list.

naved001 commented 6 years ago

start_console() and stop_console() use the client library, but show_console() doesn't. That's weird. The headnode stuff doesn't use any client library calls, but we don't need to add support for it either.

cc: @SahilTikale

zenhack commented 6 years ago

The console stuff probably isn't worth bothering with until the obmd stuff lands (or maybe we should do that at the same time).

I agree, we can omit the headnode stuff. Though it would be trivial to add if someone were going to just slog through and add all of these in one pass.

I edited your comment to turn it into a checklist; hope that's cool.

xuhang57 commented 6 years ago

Will look into this. Trying to figure out how to use the CLI for these operations first.

zenhack commented 6 years ago

Cool, I'l assign you. I've also changed the title of the issue to reflect the current thinking.

naved001 commented 6 years ago

Complete!