search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Add a subcommand on the hil tool that report the version itself #942

Closed xuhang57 closed 6 years ago

xuhang57 commented 6 years ago

This patch relates to https://github.com/CCI-MOC/hil/issues/389 And this implementation is based on the first option on @zenhack 's list.

xuhang57 commented 6 years ago

This would return: 

0.3.dev163+ga715d2e(.venv) ubuntu@lucas-hil:~/hil$ vim hil/cli.py

Any suggestion on what exactly the return value should look like?

And on github tag:https://github.com/CCI-MOC/hil/releases There is only a 0.2 release.

xuhang57 commented 6 years ago 
(.venv) ubuntu@lucas-hil:~/hil$ hil version
HIL version: 0.3.dev163+ga715d2e

Updated cli response formt. @zenhack @naved001

naved001 commented 6 years ago

Any need to rebase since I think we modified cli.py in another PR which we merged (though in different places)?

naved001 commented 6 years ago

There's a rebase and merge button too? Anybody used it before?

zenhack commented 6 years ago

Would prefer if you merged master back into your branch (don't care rebase vs. merge commit). I'd prefer not to do it on GitHub because that means we're pushing something to master that is not the exact same tree that travis is running against.

zenhack commented 6 years ago

...but I don't know that it's worth fussing about for something so small.

naved001 commented 6 years ago

Alright, I'll merge.