search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

obmd data migration script #953

Closed zenhack closed 6 years ago

zenhack commented 6 years ago

Per #928.

//cc @naved001

xuhang57 commented 6 years ago

Not familiar with obmd. But overall, Igtm.

ianballou commented 6 years ago

How is the rest of the migration strategy going to be implemented? From issue #928 I see:

  1. The final migration-script(2) will delete the old obm tables/columns, and make the OBMd stuff not nullable.

Will this cleanup happen in another file?

zenhack commented 6 years ago

@Izhmash, yeah, that would be a migration script added in hil/migrations/versions/

zenhack commented 6 years ago

...perhaps we need to plan to tag a version between this pr and the one that introduces the migration script? The strategy involves an intermediate upgrade, so we should be able to refer to the specific intermediate version.

ianballou commented 6 years ago

@zenhack I think that sounds like a good idea, yeah. Would definitely help relieve user confusion. What would be the new version number?

zenhack commented 6 years ago

@Izhmash, 0.3 is next on the list. We've got a milestone for that; maybe we should add the second part of this to the 0.4 milestone, and then start focusing on triaging the 0.3 issues so we can get that out the door.