Closed xuhang57 closed 6 years ago
Some help would be much appreciated.
I am suspecting that because this is called many time:
so the node name is not unique in the CI database?
Totals | |
---|---|
Change from base Build 1686: | 0.0% |
Covered Lines: | 2097 |
Relevant Lines: | 3534 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
hil/migrations/versions/264ddaebdfcc_make_labels_unique.py | 6 | 14 | 42.86% | ||
<!-- | Total: | 11 | 19 | 57.89% | --> |
Totals | |
---|---|
Change from base Build 1686: | -0.07% |
Covered Lines: | 2103 |
Relevant Lines: | 3548 |
Could you also write a migration script? Other than that, LGTM.
project names, switch names, network names are unique too.
Honestly, I'm not sure it's worth the effort to properly support database downgrades, and we've only been adding the function at all because alembic expects it.
I agree.
I'm happy. If everyone's in agreement re: coveralls we can just merge.
Cool, merging then.
Fix: #946
Potentially, we should think about whether there are any other constraints.
And this might break lots of tests. Consider this is an on-going implementation