Upgrade Flask from 0.10.1 -> 0.11.1 -> 0.12.1

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service

Apache License 2.0

24 stars 54 forks source link

Upgrade Flask from 0.10.1 -> 0.11.1 -> 0.12.1 #977

Closed xuhang57 closed 6 years ago

xuhang57 commented 6 years ago

Currently, the most stable release is 0.12. (http://flask.pocoo.org/docs/0.12/changelog/)

And not sure whether we should jump to 0.12 or we should go from 0.10 -> 0.11 ->0.12

Relates: https://github.com/CCI-MOC/hil/issues/975

naved001 commented 6 years ago

it's odd that the obmd migration tests are failing :/

zenhack commented 6 years ago

I suspect the test failures are due to the change in https://github.com/CCI-MOC/obmd/pull/10; we need to add the DB info to the config file we're generating there.

I'd say let's upgrade straight to 0.12.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 1743

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 59.273%

Totals
Change from base Build 1718:	-0.07%
Covered Lines:	2103
Relevant Lines:	3548

💛 - Coveralls

xuhang57 commented 6 years ago

Coverage is decreased because we never test the setup.py file?

xuhang57 commented 6 years ago

The coveralls actually shows there is no change in coverage percentage. However, the check fails here on GitHub. I will restart the build and see whether it fixes.