CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Use flask_script since flask.ext.script is deprecated (in admin.py) #982

Closed xuhang57 closed 6 years ago

xuhang57 commented 6 years ago

Change to flask_script based on the CLI prompt saying flask.ext.script is deprecated.

(.venv) ➜ ubuntu@hil-dev  ~/hil git:(master) hil-admin db create
/home/ubuntu/hil/hil/commands/admin.py:7: ExtDeprecationWarning: Importing flask.ext.script is deprecated, use flask_script instead.
  from flask.ext.script import Manager
DEBUG:passlib.registry:registered 'sha512_crypt' handler: <class 'passlib.handlers.sha2_crypt.sha512_crypt'>

Similiar to https://github.com/CCI-MOC/hil/pull/981

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 1765


Totals Coverage Status
Change from base Build 1762: 0.0%
Covered Lines: 2124
Relevant Lines: 3558

💛 - Coveralls
naved001 commented 6 years ago

Strange, I grepped for it before raising my pr and didn't see this. Sigh. Can you double check that we don't have this anywhere else in the code?

xuhang57 commented 6 years ago

@naved001 sure, you didn't find it because this is the script not the sqlalchemy ;)

xuhang57 commented 6 years ago

This is the only place I found

zenhack commented 6 years ago

LGTM, merging.