search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Travis is getting slow again #992

Closed zenhack closed 6 years ago

zenhack commented 6 years ago

See for example https://travis-ci.org/CCI-MOC/hil/builds/364351101, which took ~17 minutes. This is approaching double what it was a couple months ago.

We should figure out what's slowing it down and fix it; it's starting to get annoying.

See also #833 and #834 for general optimization ideas, though obviously measure first...

naved001 commented 6 years ago

Caching seems like a good idea to me.

Another idea: The new CLI integration tests and the client library tests take a good amount of time. We could test both of those in a different build by setting an env variable (maybe with only postgres). That way we can run CLI+client lib test (and other integration tests) in parallel with the rest of the tests.

zenhack commented 6 years ago

SQLite tends to run a bit faster than postgres; might be better to use that for tests that aren't testing anything DB related.

The client library tests were the cluprit last time as well. Per the docstring for dummy_verify:

This module pulls in way too much "real" code (as opposed to mock objects) in general, and patches to improve the situation are welcome.

zenhack commented 6 years ago

Might make sense to close this one now; we've got it down to 4-6 minutes, which is the fastest it's been in forever. Further performance improvements are always welcome, I think always welcome, but I don't think this issue is still something that needs an open ticket.