Fix new pycodestyle errors

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service

Apache License 2.0

24 stars 54 forks source link

Fix new pycodestyle errors #997

Closed naved001 closed 6 years ago

naved001 commented 6 years ago

This has @zenhack 's commit in it, and I added a commit to address the switch regexes. I ran the native networks deployment tests for both the switches and those passed. Though, the vlan_networks tests failed due to some assertions errors, looking into it right now; but I don't think these are related to this since even without these changes those failed.

I tested the powerconnect for the _console.py changes

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 1843

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+55.6%) to 55.607%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
hil/ext/switches/dellnos9.py	0	1	0.0%
<!--	Total:	0	1	0.0%	-->

Totals
Change from base Build 1832:	55.6%
Covered Lines:	2053
Relevant Lines:	3692

💛 - Coveralls

zenhack commented 6 years ago

I want to wait until you figure out what's wrong with the deployment tests, but otherwise LGTM.

naved001 commented 6 years ago

It was a couple of things:

the vlans I was using in my testsuite.cfg didn't exist on the switch (for the dellnos9), so that caused some failures.
the switchports under test weren't clean from the beginning.

I re ran both network deployment tests again on a dellnos9 switch, a powerconnect switch, and a cisco nexus switch. All passed.

naved001 commented 6 years ago

I approve of your commit at least. @Izhmash @SahilTikale could you guys review?