search

CCI-MOC / m2

Bare Metal Imaging (Malleable Metal as a Service)
18 stars 16 forks source link

Catch a bunch of errors everywhere: #170

Closed naved001 closed 3 years ago

naved001 commented 6 years ago

This PR is pretty much copy-pasta from @chemistry-sourabh's #111 PR since dealing with the merge conflicts was nasty and it made some changes which I now feel are not necessary.

This has some fixes for database issues, ceph image issues, and tgt targets. And it's weird that we have to catch integrity errors, the code should be such that it's never even raised (I'll look fix that within this PR or maybe a different one).

I will add some integration tests too.

@apoorvemohan @mihirborkar @izhmash

naved001 commented 6 years ago

Thanks for the review, but I think this will require more work once #174 is merged since that restructures a lot of things.

ianballou commented 6 years ago

How's this code looking now with the recent changes? Is everything still relevant?