CCICB / CRUX

Other
2 stars 1 forks source link

Ignore unsuitable Clinical features in drop-down for oncoplot #96

Closed selkamand closed 12 months ago

selkamand commented 1 year ago

When selecting the “Colon adenocarcinoma (N=367)” dataset, an error message appears stating “Error: cannot take a sample larger than the population when ‘replace = FALSE’” after choosing all clinical features in the oncoplot. The authors should carefully examine whether all the clinical features provided are suitable and in the correct format to be rendered in the oncoplot.

selkamand commented 1 year ago

My only concern here is it could be frustrating for a user analysing their own data to go looking for their variable of interest in the dropdown list and not see it. I think maybe we add a 'suitable for oncoplot' indicator on the dropdowns - e.g. a badge with an X if not suitable for oncoplot