search

CCIP-App / CCIP-iOS

A Community Checkin with Interactivity Project for iOS app
https://apps.apple.com/app/id1436417025
GNU General Public License v3.0
52 stars 15 forks source link

Search session #50

Closed secminhr closed 1 year ago

secminhr commented 2 years ago

Implement searching feature in ScheduleView.

It uses SwiftUI-Introspect to keep NavigationBar showing while searching (via properties provided in UIKit), it's kind of a hack. This feature is therefore proposed as a PR, rather than a direct commit.

viere1234 commented 2 years ago

Hi @secminhr! Thank you for your contribution!

This is an essential feature that needs to be implemented. But the problem is that the current method only works excellently in one-day events. If it's a multi-day event, it will cause some UI incoordination because the search bar can't interact with the form correctly. (Due to additional SelectDayView.) And I also assume that you use SwiftUI-Introspect to keep NavigationBar showing while searching because it will animate bad in a multi-day event. (Otherwise, I think it is a pretty good animation and keep the UI clean.)

So I think we should find another way to approach this feature. Or hope apple may adjust this in SwiftUI 4 (Maybe a design like Telegram that activates the search bar with a button and avoids anything but the session navigation links and places the bar on top like in EventListView?)

viere1234 commented 1 year ago

A similar function implements in 0d5ce15.