CCMS-UCSD / GNPS_Workflows

Public Workflows at GNPS
https://gnps.ucsd.edu/
Other
54 stars 44 forks source link

[GC] The balance score value is missing in the library search job output #155

Closed aaksenov1 closed 5 years ago

aaksenov1 commented 5 years ago

The balance score value is exported from the deconvolution job output and is displayed as one of the columns. The functionality is no longer present in the transferred workflow.

zhz125 commented 5 years ago

I am not sure I understand the problem.

aaksenov1 commented 5 years ago

The balance score is missing, these values are supposed to be transferred from the feature table

Annotation 2019-09-17 092153
zhz125 commented 5 years ago

job id?

aaksenov1 commented 5 years ago

https://gnps.ucsd.edu/ProteoSAFe/status.jsp?task=04e8c793b70548e18f76e680f1193265 This is an example, but it is the same for all library searches after moving from proteomics2 to gnps

aaksenov1 commented 5 years ago

https://proteomics2.ucsd.edu/ProteoSAFe/status.jsp?task=23814591421b46849462340f3a34c977

aaksenov1 commented 5 years ago

In this job balance score is displayed correctly: https://gnps.ucsd.edu/ProteoSAFe/result.jsp?task=4d50d571ecff425e925dbc9ecb98c921&view=view_all_annotations_DB&show=true So this is intermittent issue

mwang87 commented 5 years ago

This is a test case to evaluate whether the Balance Score is being produced correctly:

https://gnps.ucsd.edu/ProteoSAFe/status.jsp?task=cadde7e9dd41452fbf0418f7116224cb

The likely culprit is in this piece of code:

https://github.com/CCMS-UCSD/GNPS_Workflows/blob/master/molecular-librarysearch-gc/tools/molecularsearch-gc/add_mshub_data.py

mwang87 commented 5 years ago

Fixed, to evaluate, I have rerun the two test cases to see if it works:

https://gnps.ucsd.edu/ProteoSAFe/status.jsp?task=cadde7e9dd41452fbf0418f7116224cb https://gnps.ucsd.edu/ProteoSAFe/status.jsp?task=ade8843e1846447b8df522474787f9e0

@aaksenov1 Can you follow this progress?

mwang87 commented 5 years ago

@aaksenov1 Any progress on testing?

aaksenov1 commented 5 years ago

We re-ran all of the cdf jobs and all of them have balance score displayed correctly, so looking good.

mwang87 commented 5 years ago

Thanks, closing issue.