search

CCMS-UCSD / GNPS_Workflows

Public Workflows at GNPS
https://gnps.ucsd.edu/
Other
55 stars 44 forks source link

[MolNetEnhancer]: MetaboDistTree Qiime2 view working? #380

Open amcaraballor opened 4 years ago

amcaraballor commented 4 years ago

Does any one have a MolNetEnhancer input file that generates a good MetaboDistTree? I tested it running MolNetEnhancer with GNPS ID and NAP ID, however the MetaboDistTree Qiime2 view does not work giving the "Error: Network error, recieved 500 from server." Here one GNPS job link: https://gnps.ucsd.edu/ProteoSAFe/status.jsp?task=e0585e07b6d048c5a710ddd7fd70d3b9 If anyone has a good test file that helps to figure out the reason why this does not work I appreciate it. Maybe lack of chemical classes prediction.

mwang87 commented 4 years ago

Thanks for letting us know. Will add to set of tests @madeleineernst wondering if you could chime in on this? Let me know and we can dig into it together!

madeleineernst commented 4 years ago

Thanks @amcaraballor and @mwang87 for testing. I'll dig into it and let you know.

madeleineernst commented 4 years ago

I created a PR #387, hope that solves the issue.

amcaraballor commented 4 years ago

Thanks @madeleineernst. If the issue was fixed, it is necessary to wait for the next version release? By simply relaunching the MolNetEnhancer job does not seem to solve the issue (The direct Cytoscape visualization works fine). I tried the previous job and others with the same result. Let me know!

mwang87 commented 4 years ago

Merged in code, will put on beta server to test.

Rerun with latest version here: https://proteomics2.ucsd.edu/ProteoSAFe/status.jsp?task=9152e4283f6f4c859c39fe7e50220be3

madeleineernst commented 4 years ago

Thanks, @mwang87, can you try again with this PR #392?

mwang87 commented 4 years ago

Deployed to proteomics2. @madeleineernst can you check its working with a few tests?

madeleineernst commented 4 years ago

A new attempt, now also with tests added. The tests work for me locally: PR #416