search

CCMS-UCSD / GNPS_Workflows

Public Workflows at GNPS
https://gnps.ucsd.edu/
Other
51 stars 43 forks source link

[MS2LDA] Fixes to work with SSL #790

Closed joewandy closed 2 years ago

joewandy commented 2 years ago

Hi Ming,

The GNPS task received empty motifsets when POSTing to ms2lda in this script. This is caused by the redirect from http to https on our end. To fix this, we should POST to https too in this script. Here are some changes I made:

  1. Changed http to https.
  2. Removed the token thing as it's no longer needed. CSRF protection has been disabled from ms2lda side for the get_motifset method.
  3. Should be okay to verify the SSL cert now, so I also removed verify=False when making get/post requests.

PS. I still remember our discussion on putting motifdb to a public repo like GitHub. Will get around to doing that someday ...

Thanks, Joe

mwang87 commented 2 years ago

Thanks @joewandy merged and will try to get release middle of next week after a workshop.