search

CCMS-UCSD / GNPS_Workflows

Public Workflows at GNPS
https://gnps.ucsd.edu/
Other
56 stars 44 forks source link

Added some MotifDB test #794

Closed joewandy closed 2 years ago

joewandy commented 3 years ago

Hi Ming,

I tried to add some test for MotifDB calls. It's the test_ms2lda_motifdb() method inside ms2lda_motifdb/test/test.py. Is this the correct way to add this so it will be called by the git action? Any help or advice would be appreciated, thanks!

Also I fixed that one line in ms2lda_runfull.py as it wouldn't run before. There are some code duplications between ms2lda_runfull.py and test.py, will refactor all this at some point to tidy it up properly.

Joe

joewandy commented 2 years ago

@mwang87 I wonder if this could be merged at some point? Thanks a lot. Also, happy new year!

mwang87 commented 2 years ago

Hey @joewandy Happy New year to you as well. I shoudl be able to look at this and get it deployed on Monday afternoon.

Thanks for the patience!