CCP-NC / crystvis-js

A Three.js based crystallographic visualisation tool
https://ccp-nc.github.io/crystvis-js/
MIT License
0 stars 0 forks source link

Dependency override in package.json causes npm ci problem for npm v8.5.0 #1

Open jkshenton opened 2 years ago

jkshenton commented 2 years ago

I added

"overrides": {
    "minimist": "$minimist"
  }

to the package.json file to force a more secure minimist version to be used by a dependency. However, this causes npm ci to think the package-lock.json and package.json are out of sync and therefore the ci fails.

We could either a) fix the dependency relying on the out-of-date minimist version, b) avoid the use of npm ci (i.e. always use npm install) or c) avoid using npm <= v8.5.0.

See here https://github.com/npm/cli/issues/4684 for more on this issue.