Closed patrick-austin closed 1 year ago
Thanks a lot for raising these issues! I've linked to the relevant fixes to crystvis-js and crystcif-parse so all should be working now.
I also put in a simple notification system, so major issues parsing files etc. should now be rendered in the canvas itself.
I haven't yet updated the package on npm but will do that soon.
XYZ files
Fails with
Uncaught TypeError: r is null
- potentially due to the lack of lattice vectors? Whereas:Fails with
Uncaught Error: Invalid file format
, I tried removing theinitial_magmoms
andcastep_labels
columns but that didn't help.Originally posted by @patrick-austin in https://github.com/muon-spectroscopy-computational-project/muon-galaxy/issues/23#issuecomment-1332189159
Having looked into this further, suspect the issue with the latter is the
e-36
not being parsed correctly from theLattice
. The former will not work as it doesn't have a cell/lattice defined, so ideally this should be documented in the README and a clear error thrown.CIF files
Fails with
Uncaught The requested model does not exist
, despite containing onlyCa
,C
,O
, whereas:Works fine.
Originally posted by @patrick-austin in https://github.com/muon-spectroscopy-computational-project/muon-galaxy/issues/23#issuecomment-1332199621
I'm not familiar with the CIF format so not sure what the problem might be here - the first one may simply be incorrectly formatted.