search

CCP-WSI / research-software-directory

The Research Software Directory is a content management system that is tailored to software.
Apache License 2.0
0 stars 1 forks source link

Meta properties in header need fixing #94

Open glpoulter opened 2 years ago

glpoulter commented 2 years ago

A rendering issue was discovered when a url was input into the description field of either a project or a test case.

It turns out the meta property "description" which is in the header part of each template actually was taking the content of the description field but as it was referenced with double quotes, when a url was input into the description the first of the double quotes in the url closed the opening ones for the declaration of the meta property. Thus the rest of the description appeared in the head of the html!

Changing these double quotes to singles, as in commit https://github.com/CCP-WSI/research-software-directory/commit/57dc25642ca7dcce228b491b6d8fa90d0fdb6a25 appeared to fix the problem however presumably the intended meta data description is not what a user inputs into the description field so work still to be done

glpoulter commented 2 years ago

Single quotes as per https://github.com/CCP-WSI/research-software-directory/commit/57dc25642ca7dcce228b491b6d8fa90d0fdb6a25 seemed like a good idea but if there is a single quote in the description then the same thing happens.

For the time being have removed the meta property description (see commit referenced above) but need to workout what this actually should be and put that in instead!