search

CCSDSPy / ccsdspy

I/O interface and utilities for CCSDS binary spacecraft data in Python. Library used in flight missions at NASA, NOAA, and SWRI
https://ccsdspy.org
BSD 3-Clause "New" or "Revised" License
75 stars 18 forks source link

Remove astropy dependency #2

Closed 5tefan closed 5 years ago

5tefan commented 5 years ago

This would resolve #1, remove astropy dependency.

Code and tests updated to remove dependency. Tests passing.

TODO: have not touched the docs/ yet.

5tefan commented 5 years ago

I've been very aggressive with the simplification, esp. with a lot of the (what looks to me like) boilerplate from the cookie-cutter import. Feel free to recommend scaling back on that, but, currently, functionality appears to be preserved.

I'll look into adjusting the docs tomorrow.

ddasilva commented 5 years ago

Thanks Stefan! I appreciate the support. I'm definitely open to this if you can clear references to astropy on the docs. It should be enough to make the docs use the alabaster theme and make it so grep returns nothing for 'astropy'. Originally I was trying to integrate with astropy so I could apply to be an affiliated package and be listed on the website, but I've since lost interest. I agree this is a step in the right direction, let's bump the version up to 0.0.8 for this.

Feel free to list yourself as a co-author in the setup.py if you so fancy.

5tefan commented 5 years ago

Great. I think docs are resolved. Outside of .git/ the only mention of astro is now in the changelog via grep -r -i "astro" ..

I'll leave you as the sole author :) all I've really done is delete stuff. Again, thanks for making this open source!

5tefan commented 5 years ago

Actually, one final item: README says this is under Apache License, but the license I'm finding under licenses/ (this PR would move it to top level) looks to me like a BSD 3 clause. I specified BSD in the setup.py classifiers section. Just wanted to confirm -- this is BSD licensed? If so, should change README.

ddasilva commented 5 years ago

Oops! As far as I know BSD and Apache are compatible licenses so this shouldn't be a big deal. Let's go with Apache since that was more visible. I'll take care of that myself.