Closed ehsteve closed 1 year ago
Base: 95.89% // Head: 95.89% // No change to project coverage :thumbsup:
Coverage data is based on head (
78601bb
) compared to base (99321ed
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hey, I think this looks really good. I pulled your branch and built it locally to check it out.
Some comments (which I can do, just want your feedback). I think in this screenshot want to put the args on multiple lines so it doesn't horizontally scroll.
This is a great start, I think we should say we aim for >95% coverage, and point out some areas of growth that we want to do. In particular, I think we should list that we want to support additional data formats for packet definitions, and could use bug reports where the provided tooling requires a workaround or in adequate. Anything else you would add?
Great idea. I think need to go back and fix the formatting so it matches Restructed text.
@ddasilva ready for you to look at it again.
Thanks, will look soon, working on proposal this week. By the way, the dot command thats making the CI fail can be installed with apt-get graphviz
I pulled it and built it locally. I made a couple changes to the code example formatting and fixed the docs CI. Overall it looks good, and I am ready to merge this and rebuild the prod site if you are.
Go for it!
Still missing some dev documentation.