search

CCSDSPy / ccsdspy

I/O interface and utilities for CCSDS binary spacecraft data in Python. Library used in flight missions at NASA, NOAA, and SWRI
https://ccsdspy.org
BSD 3-Clause "New" or "Revised" License
75 stars 18 forks source link

Added GitHub integration to alabaster theme #44

Closed ehsteve closed 1 year ago

ddasilva commented 1 year ago

I kind of think having the stars count like we used to have makes more sense than the watch count. It gives a similar endorsement metric like the "used by" section. I personally never watch repositories so maybe I'm biased. What do you think?

image

codecov-commenter commented 1 year ago

Codecov Report

Base: 95.89% // Head: 95.89% // No change to project coverage :thumbsup:

Coverage data is based on head (27dbb28) compared to base (99321ed). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #44 +/- ## ======================================= Coverage 95.89% 95.89% ======================================= Files 13 13 Lines 731 731 ======================================= Hits 701 701 Misses 30 30 ``` | [Impacted Files](https://codecov.io/gh/ddasilva/ccsdspy/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+da+Silva) | Coverage Δ | | |---|---|---| | [ccsdspy/packet\_types.py](https://codecov.io/gh/ddasilva/ccsdspy/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+da+Silva#diff-Y2NzZHNweS9wYWNrZXRfdHlwZXMucHk=) | `94.44% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+da+Silva). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+da+Silva)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ehsteve commented 1 year ago

I do agree with I don't understand the documentation. They mention github_type and github_count as "options" but not sure how to toggle them and, in any case, they don't seem to be what you want. Should I get rid of it then?

ddasilva commented 1 year ago

Can we add back the code we had before to display the Github stars? I pulled it out from an old commit and pasted it below


<iframe src="https://ghbtns.com/github-btn.html?user=ddasilva&repo=ccsdspy&type=star&count=true&size=large" frameborder="0" scrolling="0" width="160px" height="30px"></iframe>
ehsteve commented 1 year ago

Done. Also added a link out to CCSDS. Not sure if you want it but seemed nice to me to provide for users.

ddasilva commented 1 year ago

Done. Also added a link out to CCSDS. Not sure if you want it but seemed nice to me to provide for users.

Github stars look good! Linking out to CCSDS is welcome

ddasilva commented 1 year ago

Production site has been rebuilt: https://ccsdspy.readthedocs.io/en/latest/