CCSDSPy / ccsdspy

I/O interface and utilities for CCSDS binary spacecraft data in Python. Library used in flight missions at NASA, NOAA, and SWRI
https://ccsdspy.org
BSD 3-Clause "New" or "Revised" License
74 stars 18 forks source link

Packaging update #52

Closed ehsteve closed 1 year ago

ehsteve commented 1 year ago

This merge request includes

This replaces my other merge request that used Poetry for packaging. The repo does not currently have git tags so the first thing to do would be to create a tag in the git history when you made the last release (0.0.13). This will then automatically create a version incremented above this to 0.1.13dev. Your version increments have not been consistent with semantic versioning so far. It should be MAJOR.MINOR.PATCH. where

  1. MAJOR version when you make incompatible API changes
  2. MINOR version when you add functionality in a backwards compatible manner
  3. PATCH version when you make backwards compatible bug fixes

You (and I) have been adding significantly more functionality so the MINOR version should have been increasing. Given that the repo already contains significant functionality and is labeled in Pypi as production stable, i would recommend that you make a release fairly soon with a version number of 1.0.0. Though technically you are not making breaking changes a 1.0 release is usually interpreted as stable. Additional functionality updates should increment the MINOR version so the next release should be 1.1

ddasilva commented 1 year ago

Thank you, this is reasonable. I made a 0.0.13 tag just now and pushed it to the repository. The next release can be 1.0.0. I can stick to semantic versioning in the future (I have used semver on other projects, even though I wasn't using it here). I think we're comfortable with freezing the API for a major release; I don't have any changes I plan on making backwards incompatible any time soon.

It looks like something broke the tests, can you look into that?

ddasilva commented 1 year ago

Closes #33 and #42

ehsteve commented 1 year ago

Oh! and I apologize, i took the liberty of adding myself as an author. Sorry I meant to mention and ask if that was okay beforehand. If you want me to make any changes, just let me know (or if you want me to add anyone else).

ehsteve commented 1 year ago

Working fixing the tests.

ehsteve commented 1 year ago

Btw, you may want to activate branch protection on main such that it does not allow you to merge without tests passing. There is a way to over-ride it if necessary but it is in red and scary looking ;)

ddasilva commented 1 year ago

Looks good to me!

Oh! and I apologize, i took the liberty of adding myself as an author. Sorry I meant to mention and ask if that was okay beforehand. If you want me to make any changes, just let me know (or if you want me to add anyone else).

I encourage this!

ddasilva commented 1 year ago

Btw, you may want to activate branch protection on main such that it does not allow you to merge without tests passing. There is a way to over-ride it if necessary but it is in red and scary looking ;)

It must have gotten lost when I changed from master to main. I re-enabled this just now