Closed ehsteve closed 1 year ago
Overall looks pretty good! I made some stylistic changes and requests to make it consistent with the rest of the documentation. Let me know when it's ready for re-review. I appreciate all the time you put into putting this together!
Implemented all of your suggestions besides the one with the question.
Looks good! I'm happy to accept this after the final modification is addressed.
Though I do have access to the Merge button now, I will not push it unless you give me explicit permission. Let me know what you want the protocol to be for me to accept merge requests or if you don't want anyone else to accept besides you.
Though I do have access to the Merge button now, I will not push it unless you give me explicit permission. Let me know what you want the protocol to be for me to accept merge requests or if you don't want anyone else to accept besides you.
Feel free to merge your own merge requests when approval has been granted! I clicked approve early because I trusted the remaining changes could be made without further review. When we have other people opening merge requests on a regular basis (its not very frequent now), we can come up with some method of shared responsibility for granting approval.
Thanks again!
@ddasilva some updates to the encoding documentation for the packet_encoding branch.
As I said, I'll keep working on this and will provide small pull requests as I implement stuff. Next stop is incorporating this functionality in the tests.