search

CCSI-Toolset / membrane_model

Membrane Separation Model: Updated hollow fiber membrane model and system example for carbon capture.
Other
3 stars 4 forks source link

lack the unit conversion of viscosity (bar*h) into (bar*s) #6

Closed KunXin666 closed 5 years ago

KunXin666 commented 5 years ago

https://github.com/CCSI-Toolset/membrane_model/blob/9eac43ec5696d3851b77d716f2afaa04a346f05b/HFGP.acmf#L185

when calculating the pressure drop in shell side, the unit of velocity is m/s, so for the viscosity (barh) should be adjusted to bars

Pret(x).ddx = -8nuret(x)`3600`*Vret(x)/((d_e/2)^2);

the same problem in the codes without sweep gas

ksbeattie commented 5 years ago

@KunXin666l, thanks for the input. I'm reaching out to other developers on getting your suggested change incorporated in.

KunXin666 commented 5 years ago

Dear Keith, noted with many thanks.

Best regards, Kun

Kun Xin

PhD candidate

[cid:062cee5c-e0c0-4b7a-b7bf-5a1c232f2ee7]

Chemical Process Intensification (SPI)

Multiphase reactors (SMR)

Dept. Chemical Engineering and Chemistry (ST)

Building 14, Helix (room STW 0.56)

Het Kranenveld

5612 AJ Eindhoven

From: Keith Beattie notifications@github.com Sent: 21 March 2019 18:54 To: CCSI-Toolset/membrane_model Cc: Xin, K.; Author Subject: Re: [CCSI-Toolset/membrane_model] lack the unit conversion of viscosity (barh) into (bars) (#6)

@KunXin666l, thanks for the input. I'm reaching out to other developers on getting your suggested change incorporated in.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCCSI-Toolset%2Fmembrane_model%2Fissues%2F6%23issuecomment-475337743&data=02%7C01%7Ck.xin%40tue.nl%7Ce410a0022ad440024d7308d6ae264ef8%7Ccc7df24760ce4a0f9d75704cf60efc64%7C1%7C1%7C636887876890853755&sdata=GGL8%2B%2Bdmn5GX1t9E4dqDLaqRSSXXzVxK7m5cCSLOsrg%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAuNlxACsB3__F-dk4ZLlQ7Tdluhgk0zcks5vY8dXgaJpZM4brgUw&data=02%7C01%7Ck.xin%40tue.nl%7Ce410a0022ad440024d7308d6ae264ef8%7Ccc7df24760ce4a0f9d75704cf60efc64%7C1%7C1%7C636887876890853755&sdata=18TaiAlhIGcXFky0sjx6DZAc6VGx7I%2BPiHLuYE7T8fs%3D&reserved=0.

ksbeattie commented 5 years ago

@KunXin666l, this should be fixed now. It will be in the next release. For the details of the fix (which ended up not being your exact suggestion) see PR #7