CCSMB-12: 3D JSON Array Format

CCSMB / Standards

Standard file formats, APIs, network protocols, and more for ComputerCraft

Other

8 stars 7 forks source link

CCSMB-12: 3D JSON Array Format #30

Open dimaguy opened 4 months ago

dimaguy commented 4 months ago

I had a brain fart today and decided to write this, open for criticism (even if it is to complain that it is overengineered).

I should write an implementation in the form of a PR to print3d if I have the time.

EmmaKnijn commented 4 months ago

Is there any reason this should be used over the regular 3dj format?

dimaguy commented 4 months ago

Is there any reason this should be used over the regular 3dj format?

Have you read any of my proposal? Reading any bit of it would get you to realize that my format doesn't replace 3dj, it allows for many 3dj models in a single file and also gives instructions to a builder on how to do it

EmmaKnijn commented 4 months ago

Is there a reason why you didnt choose to include details like light level and such in the preset? If there's a good reason i can pass this on.

did you read any bit Yes I did but I am quite stupid

dimaguy commented 4 months ago

Is there a reason why you didnt choose to include details like light level and such in the preset? If there's a good reason i can pass this on.

did you read any bit Yes I did but I am quite stupid

They arent in the preset.
They are example optional override fields

dimaguy commented 4 months ago

Oh wait I misunderstood you @EmmaKnijn They arent in the preset, because it is called in each set of bounds and not in the shape itself, you cant separate it at that point

EmmaKnijn commented 4 months ago

Alright

dimaguy commented 4 months ago

Alright

Dont forget to leave your approval if you dont want any changes

dimaguy commented 4 months ago

I will be taking a couple of days writing the requested changes (I'd be quicker but I got a test tomorrow), but in the meantime I couldn't help but notice that some of the requested changes didn't happen on other CCSMB standards already merged in (I can tell because I tried to be faithful to them as I wrote mine).

Either way they do sound reasonable and agreeable, so I recommend these guidelines be added to CCSMB-1

tomodachi94 commented 4 months ago

I will be taking a couple of days writing the requested changes (I'd be quicker but I got a test tomorrow),

Don't worry about it! The review process is inherently slow to allow ample time for at least three members to thoroughly review it. Good luck with your test! :)

but in the meantime I couldn't help but notice that some of the requested changes didn't happen on other CCSMB standards already merged in (I can tell because I tried to be faithful to them as I wrote mine).

Yes, I'm trying to hold CCSMB standards to... a higher standard. :)

Either way they do sound reasonable and agreeable, so I recommend these guidelines be added to CCSMB-1

I'm currently working on a major rework of CCSMB-1 to include far, far more guidance and some more requirements for standards :) stay tuned.